Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Insurance claiming #50

Merged
merged 34 commits into from
Nov 29, 2024
Merged

Insurance claiming #50

merged 34 commits into from
Nov 29, 2024

Conversation

@mo-c4t mo-c4t requested a review from SamJaarsma as a code owner October 18, 2024 10:37
@mo-c4t mo-c4t force-pushed the insurance-claiming branch from 645d9ed to d029583 Compare October 18, 2024 10:50
Copy link
Contributor

@SamJaarsma SamJaarsma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a couple of suggestions!

proto/cmp/types/v3/traveller.proto Outdated Show resolved Hide resolved
proto/cmp/types/v3/payment.proto Show resolved Hide resolved
Copy link
Contributor

@SamJaarsma SamJaarsma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@havan havan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added some comments for typos and a few issues with the tag numbering.

proto/cmp/services/accommodation/v3/search.proto Outdated Show resolved Hide resolved
proto/cmp/services/claim/v1/submit_claim_form.proto Outdated Show resolved Hide resolved
proto/cmp/services/claim/v1/claim_types.proto Outdated Show resolved Hide resolved
proto/cmp/services/accommodation/v3/property_types.proto Outdated Show resolved Hide resolved
proto/cmp/types/v3/file.proto Outdated Show resolved Hide resolved
proto/cmp/services/claim/v1/services.proto Outdated Show resolved Hide resolved
proto/cmp/services/claim/v1/services.proto Outdated Show resolved Hide resolved
@mo-c4t mo-c4t requested a review from havan November 25, 2024 23:16
@mo-c4t mo-c4t merged commit 95cb5a2 into dev Nov 29, 2024
8 checks passed
@mo-c4t mo-c4t deleted the insurance-claiming branch November 29, 2024 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants